[spec/test] Relax relaxed_trunc semantics#1906
Conversation
rossberg
changed the title
|
@dtig, friendly ping. |
|
Sorry to have missed this, and thanks for adding. Re. tests for regular behavior - these already exist as the original SIMD core spec tests. For example, the operations in this case would default to the ones in the deterministic profile which would be the operations introduced in the original SIMD128 proposal so in this case |
|
@dtig, well, those are different instructions. It is only an assumption that they behave the same. Verifying that is what tests are for. I mean, right now, an engine would happily pass the test suite even if its implementation of relaxed SIMD instructions was broken on almost every input. |
2 participants
@dtig, this implements the relaxation for relaxed_trunk we have converged on, PTAL.
I also removed all core tests that became obsolete/incorrect with this change. Unfortunately, it turns out that there are none left for relaxed_trunc, which is a bit concerning.
In fact, I then had a look at the tests for the other Relaxed SIMD instructions, and almost all of them only test a few edge cases. That is, with the exception of 5 assertions about
relaxed_dot, we seem to have no tests for the “regular” behaviour of these instructions at all! That’s not good. Could somebody work on creating a suitable suite of basic tests? ;)